Implement LogOutputChannel to improve logging#456
Open
JustinGrote wants to merge 1 commit intogithub:mainfrom
Open
Implement LogOutputChannel to improve logging#456JustinGrote wants to merge 1 commit intogithub:mainfrom
JustinGrote wants to merge 1 commit intogithub:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements LogOutputChannel for logging improvements, updates the ESLint configuration, and bumps the Node version for the CI builds while also refactoring several TypeScript error workarounds.
- Replace old logging functions in src/log.ts with LogOutputChannel methods.
- Update ESLint config and build workflow (Node version bump).
- Add/adjust ts-expect-error comments and reformat constructors in various modules to improve type checking with newer TypeScript rules.
Reviewed Changes
Copilot reviewed 21 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eslint.config.mjs | Introduces a flat ESLint configuration with custom ignore patterns. |
| src/log.ts | Refactors logging to use vscode.LogOutputChannel with specific log methods. |
| .github/workflows/build.yml | Updates node-version from 16.x to 20.x. |
| src/store/workflowRun.ts | Adds ts-expect-error comments for Octokit-related API calls. |
| src/pinnedWorkflows/pinnedWorkflows.ts | Introduces ts-expect-error comments and maps workflows by path. |
| src/treeViews/icons.ts | Refactors functions to return proper types (e.g. undefined instead of ""). |
| src/treeViews/settings/repoSecretsNode.ts | Adds ts-expect-error comments around repo secrets API calls. |
| src/treeViews/settings/environmentSecretsNode.ts | Updates constructor formatting and adds ts-expect-error comments. |
| src/treeViews/settings/environmentVariablesNode.ts | Updates constructor formatting and adds ts-expect-error comments. |
| src/commands/openWorkflowFile.ts | Simplifies error handling by removing unused error parameter in catch. |
| src/treeViews/settings/repoVariablesNode.ts | Adds ts-expect-error comments for repo variables API calls. |
| src/treeViews/shared/previousAttemptsNode.ts | Reformats constructor definition for clarity. |
| src/treeViews/shared/attemptNode.ts | Reformats constructor definition for clarity. |
| src/treeViews/current-branch/currentBranchRepoNode.ts | Reformats constructor definition for clarity. |
| src/treeViews/settings/environmentNode.ts | Reformats constructor definition for clarity. |
Files not reviewed (5)
- .eslintrc.json: Language not supported
- .prettierrc.json: Language not supported
- .vscode/extensions.json: Language not supported
- .vscode/settings.json: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (2)
eslint.config.mjs:13
- [nitpick] Consider renaming 'globalignores' to 'globalIgnores' for better readability and consistency with typical camelCase naming conventions.
name: "globalignores",
src/treeViews/settings/repoVariablesNode.ts:19
- [nitpick] The comment refers to 'octokit bump' in lowercase. For consistency, consider capitalizing it to 'Octokit bump'.
// @ts-expect-error FIXME: Type error after newer rules available. This will be fixed in octokit bump
JustinGrote
force-pushed
the
feature/improvedLogging
branch
from
a81a4a9 to
35d3342
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the logging API to use LogOutputChannel for automatic severities, user-selectible log levels, and better log management.
